Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: remove some data policy bits #20756

Merged
merged 4 commits into from
Jun 29, 2024

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Jun 28, 2024

Remove some data policy bits. There are still data types lingering around in some of the controller log types which aren't so easy to remove, but we can create some kind of deprecation area for such types which Ill do in a separate PR.

But this PR removes what appears to be trivial to remove as the types are not references anywhere except tests.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

dotnwat added 4 commits June 28, 2024 14:09
'twas caught but never thrown.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Presumably would not have compiled if references did exist.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
There does not appear to be any non-test user of these types.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
There does not appear to be any non-test user of the type.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Copy link
Contributor

@bharathv bharathv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0 -101

Beautiful

@dotnwat dotnwat merged commit aadf939 into redpanda-data:dev Jun 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants